feat: config file #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
feat/config-file
branch
from
b56ac7c to
e150b6e
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
| @@ -23,10 +23,17 @@ async fn main() { | |||
| // Get all the supplied flags and values | |||
| let matches = App::from_yaml(yaml).get_matches(); | |||
|
|
|||
| // Takes a path, but prepends the home directory... kinda sketchy | |||
| let endpoint_from_config = | |||
| utils::config::get_value("/.config/accf/ex.ini", "Default", "endpoint"); | |||
There was a problem hiding this comment.
Maybe this should be tested for/extended to non-MacOS also
| None => error::throw(error::Error::InvalidEndpoint), | ||
| None => match endpoint_from_config { | ||
| Some(e) => HttpAgent::new(e.as_str()), | ||
| None => error::throw(error::Error::NoSuppliedEndpoint), |
There was a problem hiding this comment.
Maybe this could be another custom error that is more specific here. Maybe sth like:
NoSuppliedEndpointInConfig
so the user knows that it's been looked for in config (after not having had a CLI flag)
| Some(c) => get_value_by_key(key, &c), | ||
| None => None, | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11