feat: able to remove an environment #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blu3beri <[email protected]>
berendsliedrecht
requested review from
jloleysens,
morrieinmaas and
karimStekelenburg
jloleysens
approved these changes
Apr 15, 2022
| @@ -105,6 +107,8 @@ impl HelpStrings { | |||
|
|
|||
| HelpStrings::Configuration => "Add agents to your configuration or view your current configuration. To quickly get started run the following command: aries-cli configuration add --default", | |||
| HelpStrings::ConfigurationAdd => "Add a new, or overwrite an existing, agent your configuration file", | |||
| HelpStrings::ConfigurationRemove => "PERMANENTLY remove an agent from your configuration", | |||
| HelpStrings::ConfigurationRemoveEnvironment => "Environment to delete", | |||
There was a problem hiding this comment.
Consistency: let's pick either "remove" or "delete". Given that the command is remove let's go with that?
There was a problem hiding this comment.
Yeah sounds good!
cli/src/modules/configuration.rs
Outdated
| debug!( | ||
| "{} environment {} from the configuration", | ||
| "Deleting".bold().red(), | ||
| environment.yellow() |
There was a problem hiding this comment.
I think we should only reach for yellow when warning about something. I think just bold works here.
There was a problem hiding this comment.
Yeah seems okay for me.
Signed-off-by: blu3beri <[email protected]>
berendsliedrecht
force-pushed
the
feat/remove-environment
branch
from
2fe666c to
eab29b9
Compare
berendsliedrecht
added a commit
to berendsliedrecht/siera-cli
that referenced
this pull request
Apr 16, 2022
Signed-off-by: blu3beri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
(@karimStekelenburg I also assigned you if you want to check it out)
Signed-off-by: blu3beri [email protected]