fix: minor bug fixes #123
Merged
fix: minor bug fixes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
morrieinmaas
approved these changes
Mar 30, 2022
jloleysens
approved these changes
Mar 30, 2022
| @@ -30,7 +30,7 @@ impl Display for Error { | |||
| Error::NoAgentURLSupplied => write!(f, "No agent URL supplied. Supply an agent URL either via `--agent-url` or see `aries-cli configuration --help` to learn about setting up an environment."), | |||
| Error::UnqualAmountKeyValue => write!(f, "Supplies keys and values are not equal in size."), | |||
| Error::HomeNotFound => write!(f, "Unable to find home directory."), | |||
| Error::ConfigExists => write!(f, "Configuration file already exists."), | |||
| Error::ConfigExists(path) => write!(f, "Configuration file already exists. If you want to add an agent, manually go to {} and add it there.", path), | |||
There was a problem hiding this comment.
Suggested change
| Error::ConfigExists(path) => write!(f, "Configuration file already exists. If you want to add an agent, manually go to {} and add it there.", path), | |
| Error::ConfigExists(path) => write!(f, "Configuration file already exists at {}.", path), |
IMO it's better to not assume what the user might want to do, but it is good to anticipate that they want to know where the file is 👌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]