-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show command output #115
Show command output #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions. Did you test it all with ./tests/run.sh and some manual stuff?
@blu3beri I did both :) The last output of the tests/run.sh was Is this expected? |
Mine does not do that. It means that the default output is not the connection id. U added a prefix to the print (connection id) in green. Couls you print that as an info? |
OK, i tested checking out the main branch (from where this branch started) and it looks like I still get that output. |
I'm going to go ahead and merge so long, happy to take on debugging tests in a follow up |
Mainly a fix to always show relevant command output when appropriate. For example, when listing all credential definitions.
Also updated contributing documentation with reasoning for when to use what type of logging.