Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offer credential workflow v1 #113

Merged
merged 4 commits into from
Mar 21, 2022
Merged

feat: offer credential workflow v1 #113

merged 4 commits into from
Mar 21, 2022

Conversation

berendsliedrecht
Copy link
Member

  • Quite a POC implementation that might need some cleanup
  • Only sends a mock cred right now to a provided connection-id
  • Debug logging is added and a decent mock credential

morrieinmaas
morrieinmaas approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@berendsliedrecht berendsliedrecht merged commit 21a1892 into main Mar 21, 2022
@berendsliedrecht berendsliedrecht deleted the workflow branch March 21, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrieinmaas morrieinmaas morrieinmaas approved these changes

@jloleysens jloleysens Awaiting requested review from jloleysens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendsliedrecht @morrieinmaas