Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: receive connection by url #108

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Conversation

berendsliedrecht
Copy link
Member

  • feat: receive connection via url
  • fix: added more trace prints

@@ -74,3 +79,27 @@ pub struct ConnectionCreateInvitationOptions {
pub multi_use: bool,
pub alias: Option<String>,
}

/// Everything is optional as most fields actually any did collides with service_endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can rephrase this comment? Doesn't make sense to me (the sentence semantically)

ConnectionSubcommands::Receive { url } => {
// Split the url
let split_url = url
.split("c_i=")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always "xxxc_i=theurlwewant" or possibly sth like "xxxc_i=theurlwewantANDSTHELSE"? Because in that case we get an invalid url. Just double checking

let invitation: ConnectionReceiveInvitationOptions =
serde_json::from_str(decoded_str)?;

agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but nice one this mechanism.

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht force-pushed the feat/connection-receive branch from b5a8028 to ef5de32 Compare March 16, 2022 14:41
@berendsliedrecht berendsliedrecht merged commit 87e8d58 into main Mar 16, 2022
@berendsliedrecht berendsliedrecht deleted the feat/connection-receive branch March 16, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants