-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: receive connection by url #108
Conversation
berendsliedrecht
commented
Mar 16, 2022
- feat: receive connection via url
- fix: added more trace prints
agent/src/modules/connections.rs
Outdated
@@ -74,3 +79,27 @@ pub struct ConnectionCreateInvitationOptions { | |||
pub multi_use: bool, | |||
pub alias: Option<String>, | |||
} | |||
|
|||
/// Everything is optional as most fields actually any did collides with service_endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can rephrase this comment? Doesn't make sense to me (the sentence semantically)
ConnectionSubcommands::Receive { url } => { | ||
// Split the url | ||
let split_url = url | ||
.split("c_i=") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always "xxxc_i=theurlwewant" or possibly sth like "xxxc_i=theurlwewantANDSTHELSE"? Because in that case we get an invalid url. Just double checking
let invitation: ConnectionReceiveInvitationOptions = | ||
serde_json::from_str(decoded_str)?; | ||
|
||
agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but nice one this mechanism.
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
b5a8028
to
ef5de32
Compare