-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
help strings for subcommands #105
Conversation
9dcf65b
to
fbc50f8
Compare
cli/src/help_strings.rs
Outdated
"Print a QR code, convenient for use with mobile apps" | ||
} | ||
// TODO: Find out what "toolbox" is | ||
HelpStrings::ConnectionsInviteToolbox => "????", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolbox is basically Aries-gui
:). This creates a toolbox specific invite
alias = toolbox
multi-use = false
auto-accept = true
and the body contains metadata that the toolbox should be admin
cli/src/help_strings.rs
Outdated
"A credential definition to base the credential on" | ||
} | ||
// TODO: What dis? | ||
HelpStrings::CredentialsOfferKey => "????", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A credential has attributes as keyvalue
name: Jean Claude Van Damme
age: 10000000
...
age is here the credentialofferkey and 10000 is here the credentialoffervalue
cli/src/help_strings.rs
Outdated
// TODO: What dis? | ||
HelpStrings::CredentialsPropose => "????", | ||
// TODO: What dis? | ||
HelpStrings::CredentialsProposeId => "????", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure hahaha
cli/src/help_strings.rs
Outdated
// TODO: What dis? | ||
HelpStrings::CredentialsOfferValue => "????", | ||
// TODO: What dis? | ||
HelpStrings::CredentialsPropose => "????", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not implemented yet, but it is another way to start an issue-credential flow.
You can propose a credential to me that I should give you. (so you ask the bank for a credential with your name, etc. in the proposal if I am not mistaken)
cli/src/help_strings.rs
Outdated
HelpStrings::SchemaCreateName => "Name of the schema", | ||
HelpStrings::SchemaCreateVersion => "Version of of the schema, useful to be able to specify multiple versions of the same schema", | ||
// TODO: What dis? | ||
HelpStrings::SchemaCreateAttributes => "????", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A credential is based on the structure of a schema.
so like before the credentialofferkeys are basically the same as the schema attributes (name, age, birthday, etc...)
@jl-animo I left some comments on your todos :) |
@blu3beri ready for round 2 |
} | ||
} | ||
} | ||
|
||
const HELP_STRING_CONNECTIONS_INVITE_TOOLBOX: &str = "Short-hand to create an invitation for the Aries Toolbox that sets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the line after the quote be on a new line? or does that ruin the printing? (its nicely formatted then in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah unfortunately this messes with the formatting when printed :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments, after those are resolved we can merge
Note