Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbosity levels #102

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Verbosity levels #102

merged 6 commits into from
Mar 15, 2022

Conversation

jl-animo
Copy link
Contributor

@jl-animo jl-animo commented Mar 15, 2022 •
edited
Loading

per the title

Notes

  • Refactored --endpoint to --agent-url -u. This was only done for the CLI facade. The config file still contains the word "endpoint". Happy to remove this change from this PR if we want to change the config file first too: just revert ed04576
  • Also added help strings for the configuration subcommands

How to test

# Show no debug or trace logs
cargo run -q -- credential-definitions
# Show debug logs, no trace logs
cargo run -q -- -v credential-definitions
# Show debug and trace logs
cargo run -q -- -vv credential-definitions
# Show debug logs, no trace logs and everything under the sun
cargo run -q -- -vvv credential-definitions

jl-animo
jl-animo commented Mar 15, 2022
View reviewed changes
cli/src/cli.rs
pub quiet: bool,

#[clap(long, short = 'o', help = HelpStrings::Config)]
pub config: Option<PathBuf>,

#[clap(long, short = 'v', default_value = "default", help = HelpStrings::Environment)]
#[clap(long, short = 'e', default_value = "default", help = HelpStrings::Environment)]
Copy link
Contributor Author

@jl-animo jl-animo Mar 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically short = 'e' is not needed

@berendsliedrecht berendsliedrecht merged commit e808656 into main Mar 15, 2022
@berendsliedrecht berendsliedrecht deleted the feat/verbosity-levels branch March 15, 2022 10:52
@jloleysens jloleysens mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jl-animo @berendsliedrecht