Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix typescript setup for demo project #3

Conversation

TimoGlastra
Copy link
Member

Fixes the typescript setup for the demo project to nicely work with the rest of the AFJ repo. Also adds the demo project to the eslint setup.

The problem was that the demo used typescript version 4.5.4, while the rest of AFJ is still using typescript version 4.30. We first need to update AFJ to support the latest typescript version: openwallet-foundation#594

Also there were issues with the package.json of the core package as a lot of recently added dependencies were removed again. I think a merge conflict or something, so I added those dependencies back in.

When running yarn annelein in the demo project I got:

    / \     _ __    _ __     ___  | |   ___  (_)  _ __  
   / _ \   | '_ \  | '_ \   / _ \ | |  / _ \ | | | '_ \ 
  / ___ \  | | | | | | | | |  __/ | | |  __/ | | | | | |
 /_/   \_\ |_| |_| |_| |_|  \___| |_|  \___| |_| |_| |_|
                                                        
", 'Agent  annelein  created', "

@TimoGlastra TimoGlastra requested review from karimStekelenburg and Annelein and removed request for karimStekelenburg January 10, 2022 13:41
Copy link

@karimStekelenburg karimStekelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Works for me too. Thanks buddy <3

@karimStekelenburg karimStekelenburg merged commit b055c1d into animo:build/demo-tsconfig Jan 10, 2022
@TimoGlastra TimoGlastra deleted the build/demo-tsconfig-updates branch March 10, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants