Example apps & documentation (usage, contribution) #19
Conversation
🦋 Changeset detectedLatest commit: 1ab38fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage report
Show new covered files 🐣
Test suite run success2 tests passing in 2 suites. Report generated by 🧪jest coverage report action from 1ab38fb |
| const recipe = cva({ | ||
| variants: { | ||
| size: { | ||
| sm: { fontSize: "sm" }, | ||
| lg: { fontSize: "lg" }, | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Arbitrary styles, we can change any of this as needed! Just a placeholder.
| --- | ||
| "@animareflection/ui": minor | ||
| --- | ||
|
|
||
| Add `Button` component |
There was a problem hiding this comment.
For future reference, no reason this changeset can't be combined with the above changeset; changesets are designed to stack. Upon a release, the changesets are "compressed" into the changelog.
| # Contributing | ||
|
|
||
| Follow the [changesets documentation](docs/changesets.md) for guidelines on how to create changesets, which describe changes you've created. |
There was a problem hiding this comment.
This file is minimal just to have a convenient and clear entrypoint to the docs/changesets.md file, though it will be expanded in the future to include all the guidelines necessary for someone to contribute smoothly.
Also note that e.g. the changesets documentation, as well as this file, will eventually be extracted to organization-wide docs so that we have one source of truth for multiple repos using this tooling.
coopbri
changed the title
coopbri
changed the title
coopbri
changed the title
coopbri
changed the title
There was a problem hiding this comment.
Files look great for the most part! Left a comment requesting one change. Will now work through manual testing steps to verify everything runs smoothly! Ty again for all this work! Exciting stuff!
EDIT: Verified that everything ran smoothly with local development in both example apps! Great work!
| @@ -14,7 +14,6 @@ | |||
| "module": "esnext", | |||
| "moduleResolution": "node", | |||
| "noEmit": true, | |||
| "outDir": "build", | |||
There was a problem hiding this comment.
This is not necessary because we have noEmit specified, which prevents TS from emitting files
Description
Task link: https://trello.com/c/qwSmnpZQ/68-ui-kit
Flex,Circle, ...)Test Steps
docs/usage.md) section to install the UI library in a separate local project (e.g. a Next.js app or similar) and make sure it works correctly (try changing Panda styles).examples/README.mdto test both the Next.js and the Vite + React example apps and make sure they work correctly (try changing Panda styles).docs/changesets.md, linked fromCONTRIBUTING.md) file. If anything is confusing, let me know.