Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor API & Docs #93

Merged
merged 5 commits into from
Jul 17, 2021
Merged

refactor API & Docs #93

merged 5 commits into from
Jul 17, 2021

Conversation

aniketmaurya
Copy link
Owner

@aniketmaurya aniketmaurya commented Jul 17, 2021

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@aniketmaurya aniketmaurya added documentation Improvements or additions to documentation enhancement New feature or request design Change API design labels Jul 17, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 17, 2021

Hello @aniketmaurya! Thanks for updating this PR.

Line 21:5: W503 line break before binary operator
Line 22:5: W503 line break before binary operator
Line 23:5: W503 line break before binary operator

Comment last updated at 2021-07-17 14:36:50 UTC

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #93 (4143fd9) into master (c50af17) will increase coverage by 0.28%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   67.55%   67.83%   +0.28%     
==========================================
  Files          34       35       +1     
  Lines        1125     1138      +13     
==========================================
+ Hits          760      772      +12     
- Misses        365      366       +1     
Flag Coverage Δ
unittests 67.83% <93.10%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/dataloader.py 44.08% <ø> (ø)
chitra/image.py 78.57% <75.00%> (ø)
chitra/serve/model_server.py 60.22% <87.50%> (+0.22%) ⬆️
chitra/__about__.py 100.00% <100.00%> (ø)
chitra/__init__.py 100.00% <100.00%> (ø)
chitra/logging.py 66.66% <100.00%> (ø)
chitra/serve/__init__.py 100.00% <100.00%> (ø)
chitra/serve/data_processing/processor.py 66.66% <100.00%> (ø)
chitra/serve/data_processing/vision.py 31.57% <100.00%> (ø)
chitra/serve/schema/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50af17...4143fd9. Read the comment docs.

@aniketmaurya aniketmaurya added this to the 0.1.0 milestone Jul 17, 2021
@aniketmaurya aniketmaurya self-assigned this Jul 17, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.1% 93.1% Coverage
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit 0490d38 into master Jul 17, 2021
@aniketmaurya aniketmaurya deleted the cleaning branch July 17, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Change API design documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants