Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove converter module #120

Merged
merged 1 commit into from
Aug 14, 2021
Merged

remove converter module #120

merged 1 commit into from
Aug 14, 2021

Conversation

aniketmaurya
Copy link
Owner

@aniketmaurya aniketmaurya commented Aug 14, 2021

Changes

Fixes #119

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #120 (bd1948e) into master (6e884c2) will increase coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   78.26%   78.51%   +0.25%     
==========================================
  Files          54       53       -1     
  Lines        1518     1494      -24     
==========================================
- Hits         1188     1173      -15     
+ Misses        330      321       -9     
Flag Coverage Δ
unittests 78.51% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/trainer.py 51.74% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e884c2...bd1948e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit db91694 into master Aug 14, 2021
@aniketmaurya aniketmaurya deleted the remove_converter branch August 14, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove converter module
1 participant