-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial RGBA16F capabilities for vc4 #115
base: master
Are you sure you want to change the base?
Conversation
Looks like a reasonable start. Note that |
Oh ok - so the actual change needs to go in here? https://github.com/torvalds/linux/tree/master/drivers/gpu/drm/vc4 |
Or if I'm just targeting Raspberry Pi - here https://github.com/raspberrypi/linux/tree/rpi-4.14.y/drivers/gpu/drm/vc4 ? |
Yeah, feel free to work against downstream rpi's kernel. The validation code hasn't changed in so long that we should be able to apply any patches that you send (to the dri-devel mailing list, since the kernel has an archaic contribution process) to master successfully. |
Great thanks for the info - I just sent the |
@anholt PTAL when you have a chance. I'm not sure we need the "is float texture" flag - can we just rely on the Also - it looks like we can rely on the nir_op-* commands for unpack and packing? |
Yeah, I'd forgotten that we had the format in the key already. Ideally we would have our texturing unpacks be in NIR, but I haven't done that yet. If we did, there would be a chance for NIR to do some useful optimizations ("oh, hey, you unpacked and then repacked the value, we can just skip that") You'll see at the end of ntq_emit_tex() that we do qir_UNPACK_8_F() for unorm8-to-float conversion, so that's the thing that would need a variant for unpacking 16f instead. |
OK thanks that is helpful - to clarify: Texture packs are handled from NIR but texture unpacks are not? |
You mean packing for TLB writes? Yeah, I moved that to NIR, and some sort of similar logic might work for texturing. (It's kind of weird because we don't get to have NIR have a different number of components returned from the texture instructions, so we'd end up having returned components that are just unused) |
WIP moving the texture unpacking to NIR for v3d, should be straightforward to use in vc4 too: https://gitlab.freedesktop.org/anholt/mesa/commits/v3d-lower-tex-results |
The NIR unpacking support is now merged: |
Thanks for the heads up -
Sorry been trying to stay low during the holiday break. I'll be back to
work next week :-)
Hope you're having a nice new year so far.
Nick
…On Fri, Jan 4, 2019 at 4:01 PM Eric Anholt ***@***.***> wrote:
The NIR unpacking support is now merged:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/45
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASsZFxh-quyhzenT3VaDBQIs5MXvPrlks5u_-t3gaJpZM4X9QxK>
.
|
Hi @anholt - here is a few things that I think are needed for #114
I am not a domain expert in drivers so I'm mostly piecing together bits that I see the v3d driver does already. Happy to iterate on this if you are open to some collaboration in helping me bridge some domain knowledge gap here.