drm/vc4: Fix NULL deref in HDMI init error path

If you make it here other than through err_destroy_encoder, vc4->hdmi is still NULL. Signed-off-by: Eric Anholt <[email protected]>
anholt · Apr 14, 2016 · 5883980 · 5883980
1 parent 08302c3
commit 5883980
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -573,7 +573,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 err_unprepare_pix:
 	clk_disable_unprepare(hdmi->pixel_clock);
 err_put_i2c:
-	put_device(&vc4->hdmi->ddc->dev);
+	put_device(&hdmi->ddc->dev);
 
 	return ret;
 }