Need to round before indexing month #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #381 - [ ] Needs tests - [ ] Needs NEWS
angusmoore
added
the
backport-pending
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 26 26
Lines 2769 2769
=======================================
Hits 2743 2743
Misses 26 26
Continue to review full report at Codecov.
|
angusmoore
added a commit
that referenced
this pull request
Aug 18, 2019
angusmoore
added a commit
that referenced
this pull request
Aug 19, 2019
angusmoore
removed
the
backport-pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some inferred months were 'correct' but when converted to integers to index into
month.abbwere rounded down. This caused #381.Closes #381