replace concat with spread: items can be arrays #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/fix-permutations
branch
from
572c823 to
fa7654d
Compare
| @@ -28,7 +28,7 @@ function permutations(arr) { | |||
| for (var j = 0, len2 = partial.length; j <= len2; j++) { | |||
| var start = partial.slice(0, j); | |||
| var end = partial.slice(j); | |||
| var merged = start.concat(first, end); | |||
| var merged = start.concat([first], end); | |||
There was a problem hiding this comment.
"first" is an item of the array being permuted. So if arr has type T[], then:
arr: T[]
first: T
start: T[]
end: T[]
The arguments to concat should both be of type T[].
The fact that this was (mostly) working before is due to JS's concat behaving somewhat like push: it can accept non-array values. But if T itself is an array type, then this did not work as intended.
|
Thanks great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526