This repository has been archived by the owner on May 20, 2023. It is now read-only.
Sync latest updates to all components #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trackBy function. This will soon be required by the angular compiler. #Cleanup. PiperOrigin-RevId: 177344955
…ackBy function. This will soon be required by the angular compiler. #Cleanup. PiperOrigin-RevId: 177348332
…ction. This will soon be required by the angular compiler. #Cleanup. PiperOrigin-RevId: 177358786
…g which can occur in production, and make one small change to catch the parse value. PiperOrigin-RevId: 177869623
…y display name. PiperOrigin-RevId: 177896573
…ent loader. PiperOrigin-RevId: 178046529
This unblocks using `ModalComponent` with `bootstrapFactory`, since it provides `ComponentLoader` in place of the deprecated `SlowComponentLoader`. PiperOrigin-RevId: 178120357
PiperOrigin-RevId: 178163860
…ed box-shadow. context: Allows two different box-shadows for expansionpanel based on its collapsed/open status. PiperOrigin-RevId: 178198194
…. This can eventually help with codesize, and saves some async calls. PiperOrigin-RevId: 178406695
…omponentLoader. PiperOrigin-RevId: 178410854
PiperOrigin-RevId: 178414500
Things that are angular @Attribute-s need to be of String type and cannot be dynamic. PiperOrigin-RevId: 178435699
…hich are faster, and produce smaller code size. PiperOrigin-RevId: 178451550
PiperOrigin-RevId: 178458547
PiperOrigin-RevId: 178458785
PiperOrigin-RevId: 178458873
* Add MaterialIconComponent to list of providers in the test component.
Fix scuba goldens due to this change.
* Remove unused variables.
* Fix some typos.
* tidy_dart
PiperOrigin-RevId: 178627056
PiperOrigin-RevId: 178700293
…nent. It is expected to bind to the `isExpanded` property, instead. While here, fixed build deps. PiperOrigin-RevId: 178774965
The former name is misleading, as a directive can always be provided locally
for injection via another token.
CL automatically created by:
replace_string \
--includefile=".*\.dart" \
\\bvisibility:\\s\*Visibility.none\\b \
visibility:\ Visibility.local
PiperOrigin-RevId: 178785979
The former name is misleading, as a directive can always be provided locally
for injection via another token.
CL automatically created by:
replace_string \
--includefile=".*\.dart" \
\\bvisibility:\\s\*Visibility.none\\b \
visibility:\ Visibility.local
PiperOrigin-RevId: 178790185
The former name is misleading, as a directive can always be provided locally
for injection via another token.
CL automatically created by:
replace_string \
--includefile=".*\.dart" \
\\bvisibility:\\s\*Visibility.none\\b \
visibility:\ Visibility.local
PiperOrigin-RevId: 178790189
The former name is misleading, as a directive can always be provided locally
for injection via another token.
CL automatically created by:
replace_string \
--includefile=".*\.dart" \
\\bvisibility:\\s\*Visibility.none\\b \
visibility:\ Visibility.local
PiperOrigin-RevId: 178790291
The former name is misleading, as a directive can always be provided locally
for injection via another token.
CL automatically created by:
replace_string \
--includefile=".*\.dart" \
\\bvisibility:\\s\*Visibility.none\\b \
visibility:\ Visibility.local
PiperOrigin-RevId: 178790618
PiperOrigin-RevId: 178806648
…uto-suggest-input widget. PiperOrigin-RevId: 178815603
Change return values of attachComponentPortal to match the return type. PiperOrigin-RevId: 178939517
…X select item padding to importable constant PiperOrigin-RevId: 178968447
…(outside of blaze). * Restore original import to allow use of the class. * Ignore the missing import for a generated file. * Add prefix to avoid error when using the ngFactory. PiperOrigin-RevId: 178971718
PiperOrigin-RevId: 179101890
…ller PiperOrigin-RevId: 179116563
PiperOrigin-RevId: 179252807
… deprecated case to make migration easier. PiperOrigin-RevId: 179273000
PiperOrigin-RevId: 179431624
…ent. PiperOrigin-RevId: 179433209
PiperOrigin-RevId: 179450549
…lear to users why that suggestion appears for the given query. PiperOrigin-RevId: 179455250
…s previously using the ComponentRenderer pattern. Also remove SupportsRendering as that was no longer being used. PiperOrigin-RevId: 179479916
PiperOrigin-RevId: 179493994
…lect to allow a path to stop using SlowComponentLoader. PiperOrigin-RevId: 179505933
PiperOrigin-RevId: 179516024
…getSelectable(item) call returns SelectableOption.Hidden PiperOrigin-RevId: 179590775
PiperOrigin-RevId: 179597576
…lar). PiperOrigin-RevId: 179607094
Update Copybara script to rewrite new .template.dart imports. PiperOrigin-RevId: 179614139
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
chalin
approved these changes
Dec 20, 2017
|
|
||
| * Material Auto-Suggest Input: Add ability to give a tooltip for the clear | ||
| icon. | ||
| * Material Expansionpanel: Add mixin for flat on collapse. |
There was a problem hiding this comment.
nit: Material Expansion Panel
|
|
||
| /// Style all scrollbars within the scope to material spec. | ||
| /// | ||
| /// Note: This is the same as material-scrollbar-theme expect it can be used |
|
|
||
| // This file is separate from has_renderer so it doesn't add in the angular | ||
| // dependency and so 'dart:html' which stops tests from running as a simple | ||
| // dart_test. |
There was a problem hiding this comment.
Minor: This comment might need to be revised. I can't quite make out what it is saying (maybe it is just because it is a run-on sentence?).
|
Thanks, I'll cleanup those comments internally but since they aren't too severe I'll export them in a future release. |
|
Good idea. |
nshahan
added a commit
that referenced
this pull request
Jan 9, 2018
Based on feedback from external sync #203 PiperOrigin-RevId: 179729861
nshahan
added a commit
that referenced
this pull request
Jan 19, 2018
Based on feedback from external sync #203 PiperOrigin-RevId: 179729861
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated version of the examples is here with the new bootstrapping setup for angular: 5.0.0-alpha+2
https://github.com/dart-lang/angular_components_example/tree/deps-update