Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Remove invalid link from OnPush compatibility warning #1930

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Remove invalid link from OnPush compatibility warning #1930

merged 3 commits into from
Oct 20, 2020

Conversation

lukaszkolodziejczyk
Copy link

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@lukaszkolodziejczyk
Copy link
Author

#1928

kevmoo
kevmoo suggested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making the first commit in a package after release, make sure to bump the version and add -dev

So angular_compiler should be at 1.0.1-dev now in pubspec.yaml

Also add a corresponding entry to the changelog

@lejard-h
Copy link
Contributor

So there is no explanation on how to fix that kind of warning ?

Except use OnPush strategy everywhere ?

@lukaszkolodziejczyk lukaszkolodziejczyk changed the title Fix invalid link to compatibility-with-default-change-detection Remove invalid link to compatibility-with-default-change-detection Oct 20, 2020
@lukaszkolodziejczyk lukaszkolodziejczyk changed the title Remove invalid link to compatibility-with-default-change-detection Remove invalid link from OnPush compatibility warning Oct 20, 2020
@lukaszkolodziejczyk lukaszkolodziejczyk merged commit d9c3754 into angulardart:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszkolodziejczyk @lejard-h @kevmoo