Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

onerror test failure #91

Closed
btford opened this issue May 2, 2015 · 1 comment
Closed

onerror test failure #91

btford opened this issue May 2, 2015 · 1 comment
Assignees

Comments

@btford
Copy link
Contributor

btford commented May 2, 2015

If you fit the currently failing onerror test, it passes.
This may be due to some zone leakage (zones not being cleaned up after a VM turn).

via @IgorMinar

@IgorMinar IgorMinar mentioned this issue May 2, 2015
@IgorMinar IgorMinar self-assigned this May 2, 2015
@IgorMinar
Copy link
Contributor

I have a PR for this

IgorMinar added a commit to IgorMinar/zone.js that referenced this issue May 2, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and build up a zone stack.

Closes angular#91
IgorMinar added a commit to IgorMinar/zone.js that referenced this issue May 2, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and build up a zone stack.

Closes angular#91
IgorMinar added a commit to IgorMinar/zone.js that referenced this issue May 2, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and build up a zone stack.

Closes angular#91
IgorMinar added a commit to IgorMinar/zone.js that referenced this issue May 7, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and build up a zone stack.

Closes angular#91
vicb pushed a commit to vicb/zone.js that referenced this issue May 7, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests
from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and
build up a zone stack.

Closes angular#91

Conflicts:
	karma-browserify.conf.js
	karma.conf.js
vicb pushed a commit to vicb/zone.js that referenced this issue May 7, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests
from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and
build up a zone stack.

Closes angular#91
vicb pushed a commit to vicb/zone.js that referenced this issue May 7, 2015
… zone

If we don't, we are leaking zones because Jasmine executes async tests
from within the done callback,
which means we never unwind the zone stack.

This causes various specs to fail if other specs run before them and
build up a zone stack.

Closes angular#91
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants