Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Notifications API is not covered by Zone.js #536

Closed
marcovdb opened this issue Dec 11, 2016 · 1 comment
Closed

Notifications API is not covered by Zone.js #536

marcovdb opened this issue Dec 11, 2016 · 1 comment

Comments

@marcovdb
Copy link

The Notifications API is not covered by Zone.js - meaning, if I initiate a notification from a zone and attach an function to the notification's onclick event, this function is not executed in the current zone.

I originally opened this as an Angular issue (angular/angular#12624) but I was asked to reopen it here, so here goes.
@JiaLiPassion
Copy link
Collaborator

Sure, several other apis are not in zone now, I would like to make a pr to implement it.

@JiaLiPassion JiaLiPassion mentioned this issue Dec 17, 2016
Merged
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Jan 14, 2017
@JiaLiPassion
fix angular#536, add notification api patch
5bf10e6
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Jan 14, 2017
@JiaLiPassion
fix angular#536, add notification api patch
3a27e39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JiaLiPassion @marcovdb