Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

build: remove webpack process and replace with tsc #626

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Aug 18, 2018

We originally recommended using Webpack and a transpilation step to improve 3rd party compatibility since 3rd party modules were often not shipped in a format compatible with NodeJS. Now we believe that the ecosystem has improved with the introduction of the Angular CLI's library bundling feature, so this is no longer needed. We are recommending not using Webpack to improve your developer experience

Copy link

@Toxicable Toxicable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs description as to why we're making this change

@clark0x
Copy link

clark0x commented Sep 18, 2018

Angular CLI's library bundling feature

@CaerusKaru do you mean bundleDependencies option in angular.json?
I can't make this option work. Have a look at angular/angular-cli#12273

@bflopez
Copy link

bflopez commented Jan 5, 2019

Hey guys, I was on reading up on the Angular Quickstart guide and it still recommends using Webpack when setting up SSR. https://angular.io/guide/universal#step-5-pack-and-run-the-app-on-the-server Anyway we can get that updated? Not sure who to address but thought this was a good place to start.

@Toxicable
Copy link

@bflopez Unfortunately we had to revert this change in #652
We thought that enough 3rd party packages had updated their build process to include Nodejs compatible artifacts, we were wrong and still rely on webpack to transform any ESM modules into CommonJS

@bflopez
Copy link

bflopez commented Jan 5, 2019

@Toxicable Ah gotcha. Ok sorry still a little confused, excuse my ignorance. Does #652 still need to be merged into master?

@keserwan
Copy link

keserwan commented Jul 4, 2019

is it now possible to build:ssr with out webpack?
I applied what you did with server.tsconfig.json but didn't work.
I am still using webpack.config

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants