Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: handle paths and line endings in a cross-platform compatible way… #19

Closed
wants to merge 1 commit into from

Conversation

steidinger
Copy link

… (#13)

Mostly I was able to normalize paths and line endings. However some files in the integration tests used mixed line endings which the eol module was unable to normalize. Therefore I decided to ignore line endings in those tests.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@steidinger
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dherges
Copy link

dherges commented Jul 5, 2017

@steidinger @chuckjaz Ok, this was on 15th of Feb ... is there any chance that his wiill get published?

@alexeagle
Copy link
Contributor

Sorry this was lost!

ts-api-guardian is moving to the main angular/angular repository. Please re-open your PR there.

You can CC me on it and I'll make sure your patch is merged this time.

@alexeagle alexeagle closed this Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants