Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(local): Ensure webdriver.gecko.driver path is passed to Selenium #4502

Merged
merged 1 commit into from
Jun 4, 2018
Merged

fix(local): Ensure webdriver.gecko.driver path is passed to Selenium #4502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/driverProviders/local.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import {Logger} from '../logger';
import {DriverProvider} from './driverProvider';

const SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
const SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
const SeleniumStandAlone = require('webdriver-manager/built/lib/binaries/standalone').StandAlone;
const remote = require('selenium-webdriver/remote');

let logger = new Logger('local');
Expand Down Expand Up @@ -151,6 +149,9 @@ export class Local extends DriverProvider {
if (this.config_.chromeDriver) {
serverConf.jvmArgs.push('-Dwebdriver.chrome.driver=' + this.config_.chromeDriver);
}
if (this.config_.geckoDriver) {
serverConf.jvmArgs.push('-Dwebdriver.gecko.driver=' + this.config_.geckoDriver);
}

this.server_ = new remote.SeleniumServer(this.config_.seleniumServerJar, serverConf);

Expand Down