This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(frameworks): allow frameworks to call afterEach.
#3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
force-pushed
the
supportAfterEach
branch
from
8f83218 to
e5c4684
Compare
juliemr
reviewed
Jan 18, 2017
| let restartDriver = () => { | ||
| browser_.restart(); | ||
| if (!this.afterEachWasCalled) { |
There was a problem hiding this comment.
Maybe if we name this boolean frameworkUsesAfterEach it would be clearer? I confused myself for a bit thinking we'd need to reset it to false (which we don't, obviously).
|
LGTM with one consideration. |
Follow up to angular#3893. Part of angular#3893
sjelin
force-pushed
the
supportAfterEach
branch
from
e5c4684 to
3397c3a
Compare
sjelin
added a commit
that referenced
this pull request
Jan 18, 2017
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
Follow up to angular#3893. Part of angular#3893
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3893.
Part of #3893
I could have just made it a noop I guess but I think it makes sense to actually use it.