Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Update @types/selenium-webdriver dependency #3886

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Update @types/selenium-webdriver dependency #3886

merged 1 commit into from
Dec 28, 2016

Conversation

pittgoose
Copy link
Contributor

Fixes issue #3879 (#3879)
Updating @types/selenium-webdriver dependency to @types/[email protected] which added back the protractor.Key.chord method.

Fixes issue #3879 (#3879)
Updating @types/selenium-webdriver dependency to @types/[email protected] which added back the protractor.Key.chord method.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pittgoose
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@sjelin
Copy link
Contributor

sjelin commented Dec 28, 2016

LGTM but @cnishina is the type expert

@cnishina cnishina merged commit eb31c9c into angular:master Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants