This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(config): cucumberOpts.require should be an optional Array of strings #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
suggested changes
Dec 12, 2016
| @@ -553,7 +553,7 @@ export interface Config { | |||
| /** | |||
| * Require files before executing the features. | |||
| */ | |||
| require?: string; | |||
| require?: Array<string>; | |||
There was a problem hiding this comment.
Nit: Prefer string[] over Array<string>
|
Since you're fixing things could you fix a couple more? :)
|
|
Will do that. dryRun is still a cucumber.js option, but protractor-cucumber-framework does not convert dryRun to --dry-run but converts it to --dryRun, which does not match, hence it will not work. |
cnishina
reviewed
Dec 14, 2016
| noSnippets?: any; | ||
| dryRun?: any; | ||
| format?: string[] | string; | ||
| // Other options include `dryRun` |
There was a problem hiding this comment.
instead of having
// Other options include `dryRun`
could we have a definition?
/**
* use dry run for ...
*/
dryRun?: boolean;
cnishina
suggested changes
Dec 14, 2016
cnishina
approved these changes
Dec 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3816