-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Proposal: add seleniumServerStartTimeout in Local DriverProvider #3791
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -29,6 +29,13 @@ export interface Config { | |||
seleniumServerJar?: string; | |||
|
|||
/** | |||
* The timeout milliseconds waiting for standalone Selenium Server to start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note that it's only for local selenium servers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjelin
Thanks, I fixed it. But...
Or other expression is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your last comment you asked: "Or other expression is better?"
What does that mean?
@@ -29,6 +29,13 @@ export interface Config { | |||
seleniumServerJar?: string; | |||
|
|||
/** | |||
* The timeout milliseconds waiting for the local standalone Selenium Server to start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be "waiting for a local Selenium Standalone Server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it.
I'm sorry for my broken English. 😢 |
cdfc5ad
to
141136a
Compare
And I squashed all commits. |
It's nice to specify how long time the Local DriverProvider waits for the selenium-webdriver server to start.
The Local DriverProvider starts local selenium-webdriver server, and waits for the server in 30,000ms now. That's because
DriverService#start()
of selenium-webdriver/remote has an argopt_timeoutMs
default 30,000ms.30,000ms is almost enough long, but that depends on environment.