Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(ExpectedConditions): non-static ExpectedConditions for browser #3766

Merged
merged 1 commit into from
Dec 1, 2016
Merged

fix(ExpectedConditions): non-static ExpectedConditions for browser #3766

merged 1 commit into from
Dec 1, 2016

Conversation

cnishina
Copy link
Member

closes #3761

@cnishina cnishina force-pushed the fix_expectedConditions branch 2 times, most recently from 924f474 to 66a86fd Compare November 28, 2016 17:09
@cnishina
Copy link
Member Author

It looks like:

  • The basic tests pass locally and on sauce.
  • when Protractor shuts down, webdriver.quit throws an error.
  • After some investigation, forking a browser instance is causing an error only in sauce labs with the spec/basic/expected_conditions_spec.js:
var browser2 = browser.forkNewDriverInstance();
browser2.get('index.html#/form');
var EC2 = browser2.ExpectedConditions;

My guess is that we are not shutting down properly and the issue might be in lib/driverProviders/driverProviders.ts and lib/driverProviders/sauce.ts...

@cnishina cnishina changed the title fix(ExpectedConditions): non-static ExpectedConditions for browser blocked fix(ExpectedConditions): non-static ExpectedConditions for browser Nov 28, 2016
@cnishina cnishina changed the title blocked fix(ExpectedConditions): non-static ExpectedConditions for browser blocked: fix(ExpectedConditions): non-static ExpectedConditions for browser Nov 28, 2016
@cnishina cnishina changed the title blocked: fix(ExpectedConditions): non-static ExpectedConditions for browser fix(ExpectedConditions): non-static ExpectedConditions for browser Nov 28, 2016
@cnishina cnishina force-pushed the fix_expectedConditions branch from 66a86fd to 1118a02 Compare November 30, 2016 22:46
@cnishina
Copy link
Member Author

cnishina commented Dec 1, 2016

Also able to reproduce with driverProviders/local 😕

@cnishina
Copy link
Member Author

cnishina commented Dec 1, 2016 •
edited
Loading

In a related issue to forking with driverProviders/local #3772

@cnishina cnishina mentioned this pull request Dec 1, 2016
Closed
@cnishina
fix(ExpectedConditions): non-static ExpectedConditions for browser
f3bb285 
- Update sauce lab binary to run on travis.
- Disable expected conditions test that forks the browser. This issue appears to
  not be specific to sauce labs. Also can reproduce this with a local driver
  provider. Additional work is required around driver providers and the runner.
- Add TODO to enable test in the future when this is resolved.

closes angular#3761
@cnishina cnishina force-pushed the fix_expectedConditions branch from 1118a02 to f3bb285 Compare December 1, 2016 18:57
@cnishina cnishina mentioned this pull request Dec 1, 2016
Closed
juliemr
juliemr reviewed Dec 1, 2016
View reviewed changes
lib/browser.ts
@@ -320,6 +320,9 @@ export class ProtractorBrowser extends Webdriver {
this.trackOutstandingTimeouts_ = !opt_untrackOutstandingTimeouts;
this.mockModules_ = [];
this.addBaseMockModules_();

// set up expected conditions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comments should be sentences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 Will fix in next PR...

@cnishina cnishina merged commit 7d481d6 into angular:master Dec 1, 2016
@cnishina cnishina deleted the fix_expectedConditions branch January 6, 2017 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliemr juliemr juliemr left review comments

Assignees
No one assigned
Labels
cla: yes pr: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with ExpectedConditions working with forked browser instances
3 participants
@cnishina @juliemr @googlebot