fix(types): fix types for element.all(...) #3656

thorn0 · 2016-10-24T23:56:00Z

Currently. all is marked as optional. It means all can be undefined, which isn't true. For this reason, it's impossible now to use element.all with TS 2.x if strictNullChecks is true. Simple code like

element.all(by.css('.info'))

leads to an error: Object is possibly 'undefined'.

thorn0 · 2016-10-24T23:57:33Z

I will rebase this after #3650 is merged. Travis won't be green till then.

thorn0 · 2016-10-25T10:20:01Z

Rebased, but something still fails on Travis. Seems unrelated to my commit.

googlebot added cla: yes labels Oct 24, 2016

fix(types): fix types for element.all(...)

71da99f

juliemr added the pr: LGTM label Oct 26, 2016

cnishina merged commit 3e4bc27 into angular:master Oct 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): fix types for element.all(...) #3656

fix(types): fix types for element.all(...) #3656

thorn0 commented Oct 24, 2016

thorn0 commented Oct 24, 2016 •

edited

Loading

thorn0 commented Oct 25, 2016

fix(types): fix types for element.all(...) #3656

fix(types): fix types for element.all(...) #3656

Conversation

thorn0 commented Oct 24, 2016

thorn0 commented Oct 24, 2016 • edited Loading

thorn0 commented Oct 25, 2016

thorn0 commented Oct 24, 2016 •

edited

Loading