This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(types): clean up TypeScript support #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
definitely_typed
branch
from
5a929e7 to
0d0e2df
Compare
cnishina
force-pushed
the
definitely_typed
branch
5 times, most recently
from
3489cd5 to
1d9d120
Compare
|
+1 |
| @@ -32,20 +33,36 @@ for (let foo in webdriver) { | |||
| exports[foo] = webdriver[foo]; | |||
| } | |||
|
|
|||
| // Explicitly define webdriver.WebDriver. | |||
| // Explicitly define webdriver.WebDriver | |||
There was a problem hiding this comment.
Please add a TODO to extend Webdriver from our typings for it.
|
Sorry this took me so long to review. Shame! I think we could use some more documentation to make navigating our TS infrastructure easier, so I requested a bit here. Feel free to leave everything else for follow-up PRs. |
cnishina
force-pushed
the
definitely_typed
branch
from
1d9d120 to
08c9527
Compare
- fix exampleTypescript to have noGlobals - change the exampleTypescript tsconfig.json to include @types - alias promise as wdpromise everywhere - refactor gulpfile task 'types' to use multiple files from tsc - add browser method types applied from webdriver this closes angular#3430, closes angular#3477, and closes angular#3500
- add comments - remove gulpfile types task - remove webdriver namespace from globals.d.ts
cnishina
force-pushed
the
definitely_typed
branch
from
08c9527 to
4345fa3
Compare
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #3430, closes #3477, and closes #3500