This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(types): split out config interface from configParser #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +86,10 @@ gulp.task('types', function(done) { | |||
|
|
|||
| // write contents to 'built/index.d.ts' | |||
| fs.writeFileSync(outputFile, contents); | |||
|
|
|||
| // copy over config.ts file so users just need to import from 'protractor/config'; | |||
There was a problem hiding this comment.
Shouldn't it be called config.ts then?
There was a problem hiding this comment.
Wait, why does this work for globals.d.ts without moving in to the root folder?
There was a problem hiding this comment.
- My comment should say
import {Config} from 'protractor/configuration';instead...but we could also doimport {Config} from 'protractor/config'; /lib/globals.d.tsis only for protractor internals to set up global variables / fix some of the missing interfaces./globals.tsexports variables from variables in the global namespace. So users can doimport {browser} from 'protractor/globals';
|
Mostly looks good except for some (probably silly) questions about where files go. |
cnishina
force-pushed
the
typings_config
branch
2 times, most recently
from
2240366 to
ae25d24
Compare
- split out config interface from configParser
- add comments from docs/referenceConf.js to lib/config.ts
- allows for users to `import {Config} from 'protractor';`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import {Config} from 'protractor';