-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(protractor): Shows locator used when a timeout occur. #3041
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
4dad6fb
to
f4107b8
Compare
@@ -401,8 +401,8 @@ Protractor.prototype.waitForAngular = function(opt_description) { | |||
} | |||
if (timeout) { | |||
var errMsg = 'Timed out waiting for Protractor to synchronize with ' + | |||
'the page after ' + timeout + '. Please see ' + | |||
'https://github.com/angular/protractor/blob/master/docs/faq.md'; | |||
'the page after ' + timeout + '. Locator: ' + description + '. Please see ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe some newlines here? Also, the description won't always be a locator
@sjelin modified the parameter sent to waitForAngular() and now the Now error message looks like this. |
closed with b6f1a63 |
For the future - changes like this are not a 'fix', since it's not fixing a bug. I would call it a 'feat' or 'chore'. |
Fixes our test failure introduced with angular#3041 Closes angular#3116
got it @juliemr , thanks. |
Fixes our test failure introduced with angular/protractor#3041 Closes #3116
Fixes #2996