Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(protractor): Shows locator used when a timeout occur. #3041

Closed
wants to merge 1 commit into from

Conversation

luishvz
Copy link
Contributor

@luishvz luishvz commented Mar 18, 2016

Fixes #2996

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@luishvz
Copy link
Contributor Author

luishvz commented Mar 18, 2016

Signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@luishvz luishvz force-pushed the issue2996 branch 4 times, most recently from 4dad6fb to f4107b8 Compare March 21, 2016 18:10
@@ -401,8 +401,8 @@ Protractor.prototype.waitForAngular = function(opt_description) {
}
if (timeout) {
var errMsg = 'Timed out waiting for Protractor to synchronize with ' +
'the page after ' + timeout + '. Please see ' +
'https://github.com/angular/protractor/blob/master/docs/faq.md';
'the page after ' + timeout + '. Locator: ' + description + '. Please see ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some newlines here? Also, the description won't always be a locator

@luishvz
Copy link
Contributor Author

luishvz commented Mar 22, 2016

@sjelin modified the parameter sent to waitForAngular() and now the description is only added to error message when is a locator.

Now error message looks like this.
Failed: Timed out waiting for Protractor to synchronize with the page after 11 seconds. Please see https://github.com/angular/protractor/blob/master/docs/faq.md - Locator: by.binding("slowAngularTimeoutPromiseStatus"). The following tasks were pending: - $timeout: function () { // intentionally empty }

@cnishina cnishina self-assigned this Mar 31, 2016
@cnishina
Copy link
Member

closed with b6f1a63

@cnishina cnishina closed this Mar 31, 2016
@juliemr
Copy link
Member

juliemr commented Apr 21, 2016

For the future - changes like this are not a 'fix', since it's not fixing a bug. I would call it a 'feat' or 'chore'.

juliemr added a commit to juliemr/protractor that referenced this pull request Apr 21, 2016
@luishvz
Copy link
Contributor Author

luishvz commented Apr 24, 2016

got it @juliemr , thanks.

bodyduardU pushed a commit to bodyduardU/protractor that referenced this pull request Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants