This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(website): fix old tests and add new ones for API page upgrades #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
referenced
this pull request
Jul 7, 2015
| @@ -133,4 +133,11 @@ describe('Api', function() { | |||
| expect(browser.getCurrentUrl()). | |||
| toMatch(/api\?view=webdriver.WebDriver.prototype.executeAsyncScript/); | |||
| }); | |||
|
|
|||
| it('should sort the menu to put webdriver docs next to the relavant ' + | |||
There was a problem hiding this comment.
nit: relevant.
Why don't we just assert expect(apiPage.getAdultNmaes()).toBe(['a', 'b', ..., 'browser', 'webdriver.WebDriver', ..., 'y', 'z'])
So we can assert all the orders?
There was a problem hiding this comment.
If the files were arranged differently the location of browser and by in the docs might be switched, but that shouldn't break the tests. This test is designed to make sure that webdriver.WebDriver comes directly after browser, since that's how the inheritance works, but not care about the absolute order of everything.
|
LGTM |
|
Merged in at 822749b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.