Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(website): API Page improvements #2287

Closed
wants to merge 3 commits into from
Closed

Conversation

sjelin
Copy link
Contributor

@sjelin sjelin commented Jun 30, 2015

Should close #2169

Review on Reviewable

@@ -121,8 +121,9 @@
* Set the extra properties used by the view to show the docs.
* @param list
*/
var itemsByName = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a property of the controller (this.itemsByName)

@juliemr
Copy link
Member

juliemr commented Jun 30, 2015

Link to the closing issue just links to itself.

@sjelin
Copy link
Contributor Author

sjelin commented Jun 30, 2015

All comments addressed

@sjelin sjelin closed this Jun 30, 2015
@sjelin sjelin reopened this Jun 30, 2015
@sjelin
Copy link
Contributor Author

sjelin commented Jun 30, 2015

(accidentally closes and re-opened)

@juliemr
Copy link
Member

juliemr commented Jun 30, 2015

Style: I find the indentation somewhat confusing. I think it would be better if the inherited from blocks were at the same indentation level as the methods... e.g. (with dots for spaces)

element(locator)
..then
..clone
..Inherited from webdriver.WebElement
..equals
..getDriver
..getId

That makes it clearer to me that getId is a method on element.

@juliemr
Copy link
Member

juliemr commented Jun 30, 2015

We should do something with the whole webdriver section at the bottom (maybe protractor and then inherits from webdrivder), but I think that should be a separate PR.

@sjelin
Copy link
Contributor Author

sjelin commented Jun 30, 2015

Fixed the indentation. I agree that it's better now. I donno what you have in mind with the webdriver section at the bottom. At least it's smaller now :P

@juliemr
Copy link
Member

juliemr commented Jun 30, 2015

LGTM.

@sjelin
Copy link
Contributor Author

sjelin commented Jun 30, 2015

Merged in at 7e8d4fd

@sjelin sjelin closed this Jun 30, 2015
@sjelin sjelin deleted the api-doc branch November 9, 2015 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The webdriver/protractor split in docs API is confusing
3 participants