-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(website): API Page improvements #2287
Conversation
@@ -121,8 +121,9 @@ | |||
* Set the extra properties used by the view to show the docs. | |||
* @param list | |||
*/ | |||
var itemsByName = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a property of the controller (this.itemsByName
)
Link to the closing issue just links to itself. |
All comments addressed |
(accidentally closes and re-opened) |
Style: I find the indentation somewhat confusing. I think it would be better if the element(locator) That makes it clearer to me that |
We should do something with the whole |
Fixed the indentation. I agree that it's better now. I donno what you have in mind with the webdriver section at the bottom. At least it's smaller now :P |
LGTM. |
Merged in at 7e8d4fd |
Should close #2169