Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Throw an error in the launcher if the user sets an unknown flag #3216

Closed
heathkit opened this issue May 12, 2016 · 1 comment
Closed

Throw an error in the launcher if the user sets an unknown flag #3216

heathkit opened this issue May 12, 2016 · 1 comment
Assignees
@cnishina
Labels
difficulty: easy hotlist: user experience type: feature request
Milestone
5.0

Comments

@heathkit
Copy link
Contributor

Some of our flags are very easy to mistype. Rather than silently ignoring unknown flags, we should at least show a warning and probably exit with an error if a user invokes Protractor with an unknown flag.
@juliemr juliemr closed this as completed Jul 14, 2016
@juliemr juliemr reopened this Jul 14, 2016
@cnishina cnishina self-assigned this Aug 5, 2016
@cnishina cnishina added this to the 4.1.0 milestone Aug 5, 2016
@cnishina
Copy link
Member

cnishina commented Aug 5, 2016

Instead of throwing an error, should we warn the user that we encountered something unexpected?

@cnishina cnishina modified the milestones: Upcoming, 4.1.0 Aug 5, 2016
@cnishina cnishina modified the milestones: 5.0, Upcoming Jan 3, 2017
cnishina added a commit to cnishina/protractor that referenced this issue Jan 3, 2017
@cnishina
chore(cli): throw errors on unknown flags
c6a5ad9 
clsoes angular#3216
@cnishina cnishina mentioned this issue Jan 3, 2017
Merged
cnishina added a commit to cnishina/protractor that referenced this issue Jan 3, 2017
@cnishina
chore(cli): throw errors on unknown flags
773208c 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 4, 2017
@cnishina
chore(cli): throw errors on unknown flags
6373e9e 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 4, 2017
@cnishina
chore(cli): throw errors on unknown flags
fa11906 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(cli): throw errors on unknown flags
533576a 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(cli): throw errors on unknown flags
e352cb5 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(cli): throw errors on unknown flags
ba752cb 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(cli): throw errors on unknown flags
30d2244 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(cli): throw errors on unknown flags
352fdc2 
clsoes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(cli): throw errors on unknown flags
d27d587 
closes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(cli): **breaking change** throw errors on unknown flags
0537599 
closes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(cli): **breaking change** throw errors on unknown flags
0a1f77d 
closes angular#3216
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(cli): **breaking change** throw errors on unknown flags
37363fd 
closes angular#3216
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cnishina cnishina

Labels
difficulty: easy hotlist: user experience type: feature request
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
4 participants
@heathkit @cnishina @juliemr @sjelin