Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
chore(cleanup): remove cucumber since it is a custom framework (#3919)
Browse files Browse the repository at this point in the history
closes #3822
  • Loading branch information
cnishina authored Jan 5, 2017
1 parent ae76c4f commit b7681c9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 31 deletions.
12 changes: 5 additions & 7 deletions docs/frameworks.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,19 @@ exports.config = {
seleniumAddress: 'http://localhost:4444/wd/hub',

baseUrl: 'https://angularjs.org/',

capabilities: {
browserName:'chrome'
},

framework: 'custom', // set to "custom" instead of cucumber.
framework: 'custom', // set to "custom" instead of cucumber.

frameworkPath: require.resolve('protractor-cucumber-framework'), // path relative to the current config file

specs: [
'./cucumber/*.feature' // Specs here are the cucumber feature files
],

// cucumber command line options
cucumberOpts: {
require: ['./cucumber/*.js'], // require step definition files before executing features
Expand All @@ -115,5 +115,3 @@ Using a Custom Framework
------------------------

Check section [Framework Adapters for Protractor](/lib/frameworks/README.md) specifically [Custom Frameworks](/lib/frameworks/README.md#custom-frameworks)


26 changes: 2 additions & 24 deletions lib/config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import {PluginConfig} from './plugins';

export interface Config {
[key: string]: any;

// ---------------------------------------------------------------------------
// ----- How to connect to Browser Drivers -----------------------------------
// ---------------------------------------------------------------------------
Expand Down Expand Up @@ -560,30 +562,6 @@ export interface Config {
*/
mochaOpts?: {[key: string]: any; ui?: string; reporter?: string;};

/**
* Options to be passed to Cucumber (when set up as a custom framework).
*/
cucumberOpts?: {
[key: string]: any;
/**
* Require files before executing the features.
*/
require?: string[] | string;
/**
* Only execute the features or scenarios with tags matching @dev.
* This may be an array of strings to specify multiple tags to include.
*/
tags?: string;
/**
* How to format features (default: progress)
*/
format?: string[] | string;
/**
* Quickly scan your features without actually running them.
*/
dryRun?: boolean;
};

/**
* See docs/plugins.md
*/
Expand Down

0 comments on commit b7681c9

Please sign in to comment.