fix(by.exactRepeater): should split by "="

Closes #2335
angular · Jul 13, 2015 · b147033 · b147033
1 parent 11a9c12
commit b147033
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/lib/clientsidescripts.js b/lib/clientsidescripts.js
@@ -107,7 +107,7 @@ functions.findBindings = function(binding, exactMatch, using, rootSelector) {
   function repeaterMatch(ngRepeat, repeater, exact) {
     if (exact) {
       return ngRepeat.split(' track by ')[0].split(' as ')[0].split('|')[0].
-          trim() == repeater;
+          split('=')[0].trim() == repeater;
     } else {
       return ngRepeat.indexOf(repeater) != -1;
     }
@@ -166,7 +166,7 @@ functions.findBindings = function(binding, exactMatch, using, rootSelector) {
   function repeaterMatch(ngRepeat, repeater, exact) {
     if (exact) {
       return ngRepeat.split(' track by ')[0].split(' as ')[0].split('|')[0].
-          trim() == repeater;
+          split('=')[0].trim() == repeater;
     } else {
       return ngRepeat.indexOf(repeater) != -1;
     }
@@ -222,7 +222,7 @@ functions.findRepeaterElement = function(repeater, exact, index, binding, using,
   function repeaterMatch(ngRepeat, repeater, exact) {
     if (exact) {
       return ngRepeat.split(' track by ')[0].split(' as ')[0].split('|')[0].
-          trim() == repeater;
+          split('=')[0].trim() == repeater;
     } else {
       return ngRepeat.indexOf(repeater) != -1;
     }
@@ -329,7 +329,7 @@ functions.findRepeaterColumn = function(repeater, exact, binding, using, rootSel
   function repeaterMatch(ngRepeat, repeater, exact) {
     if (exact) {
       return ngRepeat.split(' track by ')[0].split(' as ')[0].split('|')[0].
-          trim() == repeater;
+          split('=')[0].trim() == repeater;
     } else {
       return ngRepeat.indexOf(repeater) != -1;
     }

diff --git a/spec/basic/locators_spec.js b/spec/basic/locators_spec.js
@@ -184,6 +184,10 @@ describe('locators', function() {
       var partialRowMatch = element(
           by.repeater('baz in days').row(0));
       expect(partialRowMatch.getText()).toEqual('T');
+
+      var partialRowMatch = element(
+          by.repeater('baz in tDays').row(0));
+      expect(partialRowMatch.getText()).toEqual('T');
     });
 
     it('should return all rows when unmodified', function() {

diff --git a/testapp/repeater/repeater.html b/testapp/repeater/repeater.html
@@ -6,6 +6,9 @@
 <ul><li ng-repeat="baz in days | filter:'T'">
   <span>{{baz.initial}}</span>
 </li></ul>
+<ul><li ng-repeat="baz in tDays = (days | filter:'T')">
+  <span>{{baz.initial}}</span>
+</li></ul>
 <ul><li data-ng-repeat="day in days">
   <span>{{day.initial}}</span>
 </li></ul>