Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
chore(tests): fixes to test suite (#3496)
Browse files Browse the repository at this point in the history
- JavaScript file should use 'var' and not 'let'
- Plugin tests should use '__BASIC_PLUGIN_RAN_SETUP'
  • Loading branch information
cnishina authored Aug 24, 2016
1 parent a1b0cd7 commit 46e6e99
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion spec/dependencyTest/protractor_spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// require('protractor') equivalent is requiring ptor
let protractor = require('../../built/main');
var protractor = require('../../built/main');

// the webdriver stuff we are exposing externally

Expand Down
2 changes: 1 addition & 1 deletion spec/plugins/specs/bigger_spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
describe('check if plugin setup ran', function() {
it('should have set protractor.__BASIC_PLUGIN_RAN', function() {
expect(protractor.__BASIC_PLUGIN_RAN).toBe(true);
expect(protractor.__BASIC_PLUGIN_RAN_SETUP).toBe(true);
});

it('should have set protractor.__INLINE_PLUGIN_RAN', function() {
Expand Down
2 changes: 1 addition & 1 deletion spec/plugins/specs/fail_spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
describe('check if plugin setup ran', function() {
it('should have set protractor.__BASIC_PLUGIN_RAN', function() {
expect(protractor.__BASIC_PLUGIN_RAN).toBe(true);
expect(protractor.__BASIC_PLUGIN_RAN_SETUP).toBe(true);
});

it('should run multiple tests which fail', function() {
Expand Down

0 comments on commit 46e6e99

Please sign in to comment.