Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-prefix and md-suffix selectors should be camel-cased #2636

Closed
0x-r4bbit opened this issue Jan 13, 2017 · 2 comments · Fixed by #2639
Closed

md-prefix and md-suffix selectors should be camel-cased #2636

0x-r4bbit opened this issue Jan 13, 2017 · 2 comments · Fixed by #2639
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@0x-r4bbit
Copy link

0x-r4bbit commented Jan 13, 2017

Bug, feature request, or proposal:

This is a leftover from moving from dash-cased to camel-cased directive names.

Currently it looks like this:

<md-input-container align="end">
  <input mdInput placeholder="amount">
  <span md-prefix>$&nbsp;</span>
  <span md-suffix>.00</span>
</md-input-container>

But it should be this:

<md-input-container align="end">
  <input mdInput placeholder="amount">
  <span mdPrefix>$&nbsp;</span>
  <span mdSuffix>.00</span>
</md-input-container>
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent help wanted The team would appreciate a PR from the community to address this issue labels Jan 13, 2017
@jelbourn
Copy link
Member

We will need to support both selectors temporarily and then remove the dash-case versions in a subsequent release.

devversion added a commit to devversion/material2 that referenced this issue Jan 13, 2017
* Renames the md-prefix and md-suffix directives to camelcase.

Closes angular#2636
mmalerba pushed a commit that referenced this issue Jan 18, 2017
* Renames the md-prefix and md-suffix directives to camelcase.

Closes #2636

BREAKING CHANGE: md-prefix and md-suffix are now mdPrefix and mdSuffix
kara pushed a commit to kara/material2 that referenced this issue Jan 20, 2017
* Renames the md-prefix and md-suffix directives to camelcase.

Closes angular#2636

BREAKING CHANGE: md-prefix and md-suffix are now mdPrefix and mdSuffix
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants