Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(mdUtil): move comment nodes as well when disabling scroll #2571

Closed
wants to merge 1 commit into from
Closed

fix(mdUtil): move comment nodes as well when disabling scroll #2571

wants to merge 1 commit into from

Conversation

gustavohenke
Copy link

As comment nodes were not moved by disableScrollAround(), Angular could
misplace a few elements because of a forgotten comment node that points
to a directive.

Fixes #2456

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gustavohenke
Copy link
Author

Signed.

@googlebot
Copy link

CLAs look good, thanks!

@gustavohenke
Copy link
Author

Sorry, I incorrectly changed the file via GitHub, this patch will not work.
I'll fix and squash locally in a minute.

As comment nodes were not moved by disableScrollAround(), Angular could
misplace a few elements because of a forgotten comment node that points
to a directive.

Fixes #2456
@gustavohenke
Copy link
Author

Now it'll be okay.

@rschmukler rschmukler closed this Apr 27, 2015
@rschmukler
Copy link
Contributor

Thanks @gustavohenke

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-select moves DOM elements and puts them back in the wrong position
3 participants