Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Apply md-dialog styles only to direct child md-content element #2418

Closed
wants to merge 1 commit into from
Closed

Apply md-dialog styles only to direct child md-content element #2418

wants to merge 1 commit into from

Conversation

brettstack
Copy link
Contributor

This prevents the style being applied to other md-content elements.

This prevents the style being applied to other md-content elements.
@brettstack brettstack deleted the patch-1 branch April 22, 2015 16:15
@marcysutton
Copy link
Contributor

Why are there multiple md-content elements? This causes problems when it isn't the direct descendant, like in the use case where a form has to wrap both the dialog content and the actions. #2514

If the padding is an issue, why can't the nested element be a <div>?

@brettstack
Copy link
Contributor Author

My bad. The multiple md-content is a result of me trying to make my
directives super reusable (and failing). This style should either be
removed or perhaps instead use :first-child-of-type (untested bit should
work?).

On Fri, 24 Apr 2015 3:12 pm Marcy Sutton [email protected] wrote:

Why are there multiple md-content elements? This causes problems, and is
not recommended as a solution. #2514
#2514


Reply to this email directly or view it on GitHub
#2418 (comment).

@marcysutton
Copy link
Contributor

Good idea, I'll investigate alternate selectors. Knowing the use case helps (reusable directives). It is probably a good idea to avoid nesting md-content if it stacks up padding.

@marcysutton
Copy link
Contributor

Actually we're going to change md-content inside of a dialog to md-dialog-content, similar to md-card which has md-card-content. That will eliminate the problem entirely. I'll be sure to make note of it in commits and the Changelog!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants