Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

docs(eol): updates for End-of-Life #12152

Merged
merged 2 commits into from
Mar 22, 2022
Merged

docs(eol): updates for End-of-Life #12152

merged 2 commits into from
Mar 22, 2022

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Mar 3, 2022 •
edited
Loading

PR Checklist

Please check your PR fulfills the following requirements:

  • Does this PR fix a regression since 1.2.0, a security flaw, or a problem caused by a new browser version?
  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • The README
    • lists LTS details that have expired
    • doesn't mention the EOL status
    • has docs for contributing, but we aren't accepting any contributions
    • links to the forums and Gitter for official support, which is no longer available

What is the new behavior?

  • change LTS section of README to an End-of-Life section
    • remove LTS details
  • add link to AngularJS EOL blog post
  • remove release and contributing docs from README
    • remove Gitter and Google Groups forum links as they will no longer be supported
  • update Copyright year in LICENSE
  • fix broken Ionic v1 link
  • remove README contributing link, forums link, and Gitter link from Getting Started page

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Related to angular/angular.js#17177.

cc: @mgol @mgechev @gkalpak @aaronfrost

@Splaktar Splaktar added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Mar 3, 2022
@Splaktar Splaktar added this to the 1.2.5 milestone Mar 3, 2022
@Splaktar Splaktar self-assigned this Mar 3, 2022
@Splaktar Splaktar changed the title docs(eol): updates for End-of-Life docs(eol): README updates for End-of-Life Mar 3, 2022
@Splaktar Splaktar requested a review from jelbourn March 3, 2022 19:24
@Splaktar Splaktar changed the title docs(eol): README updates for End-of-Life docs(eol): updates for End-of-Life Mar 3, 2022
@Splaktar Splaktar mentioned this pull request Mar 8, 2022
Merged
4 tasks
jelbourn
jelbourn reviewed Mar 10, 2022
View reviewed changes
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/docs.md Outdated Show resolved Hide resolved
Splaktar added 2 commits March 10, 2022 02:03
@Splaktar
docs(eol): updates for End-of-Life
607d960 
- change LTS section of README to an End-of-Life section
  - remove LTS details
- add link to AngularJS EOL blog post
- remove release and contributing docs from README
  - remove Gitter and Google Groups forum links as they will no longer be supported
- update Copyright year in LICENSE
- fix broken Ionic v1 link
- remove README contributing link, forums link, and Gitter link from Getting Started page
@Splaktar
docs(github): update GH templates for EOL
d99eef4 
- update bug, docs, and PR templates for EOL
- update CONTRIBUTING.md for EOL
- remove links to AngularJS Material forums and Gitter channel
  from GH contact links as they are no longer supported
@Splaktar Splaktar force-pushed the update-readme-for-eol branch from 04eaad8 to d99eef4 Compare March 10, 2022 07:03
@Splaktar Splaktar requested a review from jelbourn March 10, 2022 07:08
@Splaktar
Copy link
Member Author

Review feedback addressed.

jelbourn
jelbourn approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit c9f67b3 into master Mar 22, 2022
@Splaktar Splaktar deleted the update-readme-for-eol branch March 22, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@Splaktar Splaktar

Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Milestone
1.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Splaktar @jelbourn