This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): memory leak on destroy #11145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
the
needs: more info
|
Do you have a CodePen or repro steps for the docs or something that can help to reproduce this issue? Is there a related issue open already? Is it related to #11133? |
Splaktar
changed the title
Splaktar
added
type: bug
severity: memory leak
Splaktar
added
needs: review
Splaktar
added
the
P1: urgent
|
Excellent, thank you! I will do some manual testing to verify the fix. Can you please update the commit message to add |
|
Yes will add. |
When destroying md-tooltip the callback `onDomAdded` remained attached and was causing a memory leak. Added 4 lines with setting all 4 callbacks to null in `MdPanelRef.prototype.destroy`. Fixes angular#11133
|
Done |
Splaktar
removed
the
needs: manual testing
Splaktar
added
pr: merge ready
|
This is currently triggering some presubmit failures that appear to be flakes (i.e. from flaky tests, not actual real failures). This is being looked at internally by Google. No work is needed on your side at this time. |
|
Passes presubmit |
Splaktar
added
resolution: fixed
and removed
pr: presubmit-failures
resolution: fixed
labels
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
When destroying md-tooltip the callback `onDomAdded` remained attached and was causing a memory leak. Added 4 lines with setting all 4 callbacks to null in `MdPanelRef.prototype.destroy`. Fixes angular#11133
Splaktar
pushed a commit
that referenced
this pull request
Jul 31, 2018
When destroying md-tooltip the callback `onDomAdded` remained attached and was causing a memory leak. Added 4 lines with setting all 4 callbacks to null in `MdPanelRef.prototype.destroy`. Fixes #11133
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When destroying md-tooltip the callback
onDomAddedremained attached and was causing a memory leak.Issue Number:
#11133
What is the new behavior?
Added 4 lines with setting all 4 callbacks to null in
MdPanelRef.prototype.destroy.From my tests this will clear the memory leak.
Does this PR introduce a breaking change?
Other information