-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(panel): loosen up bounds assessment #10651
fix(panel): loosen up bounds assessment #10651
Conversation
getBoundingClientRect() will return a width of 0 in certain scenarios. Retrieving the width through clientWidth will hold the desired width for the position calculation. As this can be reversed for other situations, we take the max of both values. Closes #10543
The |
@ErinCoughlan care to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DerekLouie I think this is the cause of the sliding animation bug as well.
Any updates here @ThomasBurleson ? |
@oliversalzburg - lgtm |
@ThomasBurleson Awesome :) What does the |
@oliversalzburg - No, that is a flag used to indicate |
@ThomasBurleson what is the timeline for the next version and the pull/merge requests? This request is there for 3 months already and not merged yet and no new release. At our project we are still on 1.1.1 which also has exceptions for some components but updating is no choice since the last "bugfix" releases introduced new features and new bugs. So pls.: focus on bugfixes, close every new feature and bring this project to a stable version for the "end". Best, |
@ThomasBurleson why is this now marked with 1.1.6 instead of 1.1.5? Without this fix tooltips are not usable in the described cases. |
@ErinCoughlan @EladBezalel can you push it somehow forward to version 1.1.5? what is missing here to have it merged? with debugInfoEnabled(false) the tooltips are not usable so an update is not possible for us. |
@IMM0rtalis as i said in - #9379 (comment) |
@Splaktar Heyho, I wish you a happy new year! Again another month passed without any change here. It is really frustrating. This PR is RDY since may!!! If every bugfix needs a year of merging-time we will be doomed! :( |
I'm assuming this means that Google is using angular-material is some of their own products and, with this change, there are issues in their product. So there is really nothing to be done by outsiders, except waiting or forking. Let me know if you're forking! 😄 |
Sorry for the delay. I am working to get more details on what kind of failures have been encountered. Obviously I can't just get access to the test results as there may be confidential information in them. As @oliversalzburg mentioned, there is nothing that the community can do at this time. Google is very hesitant to make breaking changes to this library. It is in production in many internal and external applications around the world. These applications may depend upon the current behavior (even if erroneous). For now, my focus is on getting all of the PRs merged that don't cause any breakages. Once those are all handled, I will push hard to get PRs merged that fix bugs and seem to be caught by tests that are too specific or false positives. |
@IMM0rtalis it looks like we've managed to get this through the presubmit phase. Hoping to be able to merge very soon. |
getBoundingClientRect()
will return a width of 0 in certain scenarios.Retrieving the width through
clientWidth
will hold the desired width for the position calculation.As this can be reversed for other situations, we take the max of both values.
Closes #10543