Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Restore tab content animations in Dynamic Tabs demo #717

Closed
ThomasBurleson opened this issue Nov 21, 2014 · 1 comment
Closed

Restore tab content animations in Dynamic Tabs demo #717

ThomasBurleson opened this issue Nov 21, 2014 · 1 comment
Assignees
Milestone

Comments

@ThomasBurleson
Copy link
Contributor

During the commit d3bab566ec71ff, the Tab demos lost their enter/leave animations in the styles.css.
Let's restore these.

@ThomasBurleson ThomasBurleson added this to the 0.7.0-rc1 milestone Nov 21, 2014
@robertmesserle
Copy link
Contributor

@ThomasBurleson I am not entirely sure what this is referring to.

@robertmesserle robertmesserle changed the title Restore tab animations in Demos Restore tab content animations in Dynamic Demo Dec 2, 2014
@robertmesserle robertmesserle changed the title Restore tab content animations in Dynamic Demo Restore tab content animations in Dynamic Tabs demo Dec 2, 2014
robertmesserle added a commit that referenced this issue Dec 18, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
robertmesserle added a commit that referenced this issue Dec 19, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
robertmesserle added a commit that referenced this issue Dec 19, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Dec 19, 2014
robertmesserle added a commit that referenced this issue Dec 20, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.

refactor(tabs): removes unnecessary check
robertmesserle added a commit that referenced this issue Jan 8, 2015
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.

refactor(tabs): removes unnecessary check
@ajoslin ajoslin removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs resolution: fixed labels Jan 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants