Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fab Speed Dial throws error when opening a md-dialog #3213

Closed
cebor opened this issue Jun 10, 2015 · 7 comments
Closed

Fab Speed Dial throws error when opening a md-dialog #3213

cebor opened this issue Jun 10, 2015 · 7 comments
Assignees
@topherfangio
Milestone
1.0-rc1

Comments

@cebor
Copy link
Contributor

cebor commented Jun 10, 2015

Got following error in Chrome when opening a Dialog with a Fab Speed Dial Button.

Error: [$rootScope:inprog] $digest already in progress
http://errors.angularjs.org/1.4.0/$rootScope/inprog?p0=%24digest
    at angular.js:68
    at beginPhase (angular.js:16073)
    at Scope.$apply (angular.js:15817)
    at HTMLButtonElement.FabSpeedDialController.vm.close (angular-material.js:5515)
    at HTMLButtonElement.jQuery.event.dispatch (jquery.js:4435)
    at HTMLButtonElement.elemData.handle (jquery.js:4121)
    at HTMLButtonElement.jQuery.event.special.focus.trigger (jquery.js:4596)
    at Object.jQuery.event.trigger (jquery.js:4316)
    at HTMLButtonElement.<anonymous> (jquery.js:4901)
    at Function.jQuery.extend.each (jquery.js:374)

Using: v0.10.0 with chrome on osx

codepen: http://codepen.io/anon/pen/KpyoJb?editors=101
@cebor cebor changed the title Fab Speed Dial throws error when opening a Dialog Fab Speed Dial throws error when opening a md-dialog Jun 12, 2015
@ThomasBurleson ThomasBurleson self-assigned this Jun 16, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Jun 16, 2015
@cebor cebor mentioned this issue Jun 18, 2015
Closed
2 tasks
@ryanstrandt
Copy link

Is this the same for sideNav? I have used a fab on click to open sideNav but, as soon as I add the md-fab-speed-dial directive, the same action throws a rootScope:inprog error.

@topherfangio
Copy link
Contributor

@cebor Sorry for the delay in getting to this. Any chance you can provide some example code?

Are you trying to open the dialog when a speed dial item is clicked, or are you trying to put the speed dial inside of the dialog?

@cebor
Copy link
Contributor Author

cebor commented Jun 24, 2015

@topherfangio

http://codepen.io/anon/pen/KpyoJb?editors=101

just open the speed dial menu and click on the face, then you will see the error in the console.

@topherfangio
Copy link
Contributor

Awesome, thanks! I'm definitely seeing the error.

I'll dig in to find a solution.

topherfangio added a commit that referenced this issue Jun 26, 2015
@topherfangio
fix(fabSpeedDial): fix $digest in-progress error when opening a dialog
d491cfd 
cebor reported a $digest in progress bug when trying to open a dialog
from within the speed dial; haven't figured out how to create a test
that demonstrates it, but I added a demo which shows failure

references #3213
topherfangio added a commit that referenced this issue Jun 26, 2015
@topherfangio
fix(fabSpeedDial): fix many visual issues
9335f61 
 * maintain state when focusing/bluring/tabbing through actions

   speed dial would previously show a very short and erroneous animation
   when tabbing, or rapidly blurring/focusing, through child items

 * add demo showing tooltip usage

 * fix $digest in-progress error when opening a dialog

   cebor reported a $digest in progress bug when trying to open a dialog
   from within the speed dial; haven't figured out how to create a test
   that demonstrates it, but I added a demo which shows failure

 * animations fail on Safari

   update webkitTransform styles and set height to initial instead of 100%

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
@topherfangio topherfangio mentioned this issue Jun 26, 2015
Closed
topherfangio added a commit that referenced this issue Jun 28, 2015
@topherfangio
fix(fabSpeedDial): fix many visual issues
d09952f 
 * maintain state when focusing/bluring/tabbing through actions

   speed dial would previously show a very short and erroneous animation
   when tabbing, or rapidly blurring/focusing, through child items

 * add demo showing tooltip usage

 * fix $digest in-progress error when opening a dialog

   cebor reported a $digest in progress bug when trying to open a dialog
   from within the speed dial; haven't figured out how to create a test
   that demonstrates it, but I added a demo which shows failure

 * animations fail on Safari

   update webkitTransform styles and set height to initial instead of 100%

 * make changes suggested by gkalpak

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
topherfangio added a commit that referenced this issue Jun 28, 2015
@topherfangio
fix(fabSpeedDial): fix many visual issues
78fcf18 
 * maintain state when focusing/bluring/tabbing through actions

   speed dial would previously show a very short and erroneous animation
   when tabbing, or rapidly blurring/focusing, through child items

 * add demo showing tooltip usage

 * fix $digest in-progress error when opening a dialog

   cebor reported a $digest in progress bug when trying to open a dialog
   from within the speed dial; haven't figured out how to create a test
   that demonstrates it, but I added a demo which shows failure

 * animations fail on Safari

   update webkitTransform styles and set height to initial instead of 100%

 * make changes suggested by gkalpak

 * more fixes suggested by gkalpak

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
@animesh1987
Copy link

+1

topherfangio added a commit that referenced this issue Jul 5, 2015
@topherfangio
fix(fabSpeedDial): fix many visual issues
8081404 
 * maintain state when focusing/bluring/tabbing through actions

   speed dial would previously show a very short and erroneous animation
   when tabbing, or rapidly blurring/focusing, through child items

 * add demo showing tooltip usage

 * fix $digest in-progress error when opening a dialog

   cebor reported a $digest in progress bug when trying to open a dialog
   from within the speed dial; haven't figured out how to create a test
   that demonstrates it, but I added a demo which shows failure

 * animations fail on Safari

   update webkitTransform styles and set height to initial instead of 100%

 * make changes suggested by gkalpak

 * more fixes suggested by gkalpak

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
@Chentai-Kao
Copy link

+1

1 similar comment
@LexFrench
Copy link

+1

@angular angular locked and limited conversation to collaborators Jul 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
None yet
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

fix(fabSpeedDial): fix many visual issues angular/material
7 participants
@ryanstrandt @topherfangio @ThomasBurleson @Chentai-Kao @LexFrench @cebor @animesh1987