Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

input: ng-messages animation errors #10461

Closed
ThomasBurleson opened this issue Mar 6, 2017 · 9 comments · Fixed by #11352
Closed

input: ng-messages animation errors #10461

ThomasBurleson opened this issue Mar 6, 2017 · 9 comments · Fixed by #11352
Assignees
@Splaktar
Labels
for: internal contributor The team will address this issue and community PRs are not requested. has: Pull Request A PR has been created to address this issue hotlist: animations P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed type: bug
Milestone
1.1.11

Comments

@ThomasBurleson
Copy link
Contributor

screen shot 2017-03-06 at 3 44 25 pm

screen shot 2017-03-06 at 3 44 11 pm

Visible with ng 1.5.x and 1.6.x
@ThomasBurleson ThomasBurleson added this to the 1.1.4 milestone Mar 6, 2017
@ThomasBurleson ThomasBurleson added P0: critical Critical issues that must be addressed immediately. - Change milestone P1: urgent Urgent issues that should be addressed in the next minor or patch release. and removed P0: critical Critical issues that must be addressed immediately. - Change milestone labels Mar 6, 2017
@EladBezalel
Copy link
Member

Also happens on 1.5.5 - repro on 1.6.2 aswell

@topherfangio as the one who wrote this code, do you know what's going on?

@rw-bkew
Copy link

rw-bkew commented Mar 8, 2017

I am also seeing this in 1.1.3

@mckenzielong
Copy link
Contributor

I've also seen the opposite where input errors can stick, however I am having trouble duplicating in a codepen. Here is a tiny code pen for demonstrating something similar to what @ThomasBurleson is showing:

https://codepen.io/mckenzielong/pen/qmZVyo

  1. Show field
  2. enter an invalid number (say 500)
  3. click submit
  4. hide field and reshow

@tamsler
Copy link

tamsler commented May 5, 2017

We are seeing this issue as well:
using:
Angular Material v1.1.4
Angular v1.6.4

@ThomasBurleson ThomasBurleson modified the milestones: 1.1.4, 1.1.5 May 7, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.5, 1.1.6 Sep 5, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar modified the milestones: 1.1.7, 1.1.8 Jan 29, 2018
@Splaktar Splaktar changed the title mdInput messages animation errors input: ng-messages animation errors Mar 16, 2018
@Splaktar Splaktar added the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Mar 16, 2018
@Splaktar Splaktar modified the milestones: 1.1.8, 1.1.9 Mar 16, 2018
@Splaktar Splaktar mentioned this issue Mar 16, 2018
Closed
@Splaktar Splaktar modified the milestones: 1.1.9, 1.1.10 Apr 19, 2018
@AnushaputtaUI
Copy link

I know this was a long ago but anyone know how to solve this issue?

@Splaktar Splaktar assigned Splaktar and unassigned EladBezalel Jun 10, 2018
@Splaktar
Copy link
Member

@AnushaputtaUI no one has investigated this issue yet. If you'd like to look into it, I'd like to know what you find. If you can find a solution, then sending a PR would be great.

Verified that it still exists with AngularJS 1.7.0 and AngularJS Material 1.1.9 in this updated CodePen.

@Splaktar Splaktar added for: internal contributor The team will address this issue and community PRs are not requested. for: external contributor labels Jun 10, 2018
@Splaktar Splaktar modified the milestones: 1.1.10, 1.1.11 Jun 26, 2018
@marosoft
Copy link
Contributor

marosoft commented Jun 29, 2018 •
edited by Splaktar
Loading

This was implemented in ce5f7c2

This was to fix a problem with displaying the messages.
However I am not sure why this introduced showing warnings when ng-messages are not provided.

There are situations like the one provided in the demo where you just would like to highlight the problematic field but without showing any extra error messages.

I believe the fix required was in 4 lines (the rest was not really needed):
ce5f7c2#diff-da06475ed96460fbcb944d6f1f31748aR1059

I will test it.

marosoft added a commit to marosoft/material that referenced this issue Jun 29, 2018
@marosoft
fix(input): remove unnecessary warnings when ng-messages not provided
1eed52d 
There is no requirement to include the messages in case of an error.
Highlighting the field can be enough.

Fixes angular#10461
@marosoft marosoft mentioned this issue Jun 29, 2018
Merged
3 tasks
@marosoft
Copy link
Contributor

Adding CodePen with my fix applied.

@marosoft
Copy link
Contributor

marosoft commented Jun 29, 2018 •
edited
Loading

Adding CodePen for the other issue #9468. Fix for the autocomplete introduced the warnings in the console. This is to show that the fix itself is still working fine after implementing my changes.

@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Jul 5, 2018
marosoft added a commit to marosoft/material that referenced this issue Jul 6, 2018
@marosoft
fix(input): remove unnecessary warnings when ng-messages not provided
3fcd61f 
There is no need to trigger the animations
if there are no messages to animate in.

Fixes angular#10461
marosoft added a commit to marosoft/material that referenced this issue Jul 11, 2018
@marosoft
fix(input): remove unnecessary warnings when ng-messages not provided
f7d812e 
There is no requirement to include the messages in case of an error.
Highlighting the field can be enough.

Fixes angular#10461
mmalerba pushed a commit that referenced this issue Jul 26, 2018
@marosoft @mmalerba
fix(input): remove unnecessary warnings when ng-messages not provided (…
d48c5b8 
…#11352)

There is no requirement to include the messages in case of an error.
Highlighting the field can be enough.

Fixes #10461
Splaktar pushed a commit that referenced this issue Jul 31, 2018
@marosoft @Splaktar
fix(input): remove unnecessary warnings when ng-messages not provided (…
ccf6329 
…#11352)

There is no requirement to include the messages in case of an error.
Highlighting the field can be enough.

Fixes #10461
Splaktar pushed a commit that referenced this issue Aug 2, 2018
@marosoft @Splaktar
fix(input): remove unnecessary warnings when ng-messages not provided (…
687d0a8 
…#11352)

There is no requirement to include the messages in case of an error.
Highlighting the field can be enough.

Fixes #10461
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
for: internal contributor The team will address this issue and community PRs are not requested. has: Pull Request A PR has been created to address this issue hotlist: animations P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed type: bug
Projects
None yet
Milestone
1.1.11
Development

Successfully merging a pull request may close this issue.

fix(input): remove unnecessary warnings when ng-messages not provided marosoft/material
9 participants
@tamsler @topherfangio @ThomasBurleson @Splaktar @marosoft @EladBezalel @mckenzielong @rw-bkew @AnushaputtaUI