fix(tabs): remove window resize listener on $destroy

Closes #254
angular · Sep 9, 2014 · 4b887f1 · 4b887f1
1 parent 738bb42
commit 4b887f1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/base/constants.js b/src/base/constants.js
@@ -32,6 +32,7 @@ var Constant = {
   EVENTS : {
     TABS_CHANGED : '$materialTabsChanged',
     FOCUS_CHANGED : '$materialFocusChanged',
-    WINDOW_RESIZE : 'resize'
+    WINDOW_RESIZE : 'resize',
+    SCOPE_DESTROY : '$destroy'
   }
 };
diff --git a/src/components/tabs/js/tabsDirective.js b/src/components/tabs/js/tabsDirective.js
@@ -178,8 +178,14 @@ function TabsDirective($q, $window, $timeout, $compile, $materialEffects, $$rAF,
               $$rAF( updateInk );
             };
 
+        var onWindowResize = $$rAF.debounce( updateAll );
+        var onWindowRelease = function() {
+              angular.element($window).off('resize', onWindowResize);
+            };
+
+        angular.element($window).on( Constant.EVENTS.WINDOW_RESIZE, onWindowResize);
         scope.$on( Constant.EVENTS.TABS_CHANGED, updateAll );
-        angular.element($window).on( Constant.EVENTS.WINDOW_RESIZE, $$rAF.debounce( updateAll ));
+        scope.$on( Constant.EVENTS.SCOPE_DESTROY,onWindowRelease );
 
         transcludeHeaderItems();
         transcludeContentItems();