Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

(api): fxFlex ignores basis value when using .lt-md #528

Closed
alusev opened this issue Dec 7, 2017 · 3 comments · Fixed by #629
Closed

(api): fxFlex ignores basis value when using .lt-md #528

alusev opened this issue Dec 7, 2017 · 3 comments · Fixed by #629
Assignees
@ThomasBurleson @CaerusKaru
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v5.0.0-beta.14

Comments

@alusev
Copy link

alusev commented Dec 7, 2017 •
edited by ThomasBurleson
Loading

The following configuration fxFlex="grow" fxFlex.lt-md="1 0 50%" should set basis value to 50% when the screen size is less than 960px.

What is the current behavior?

Only the shrink value changes.

What are the steps to reproduce?
@ThomasBurleson
Copy link
Contributor

The StackBlitz Demo has been upgraded to @angular/flex-layout 2.0.0-beta.12; and with changes to fxFlex="1 1 50%" it appears to be working now.

screen shot 2017-12-15 at 7 38 53 am

@ThomasBurleson ThomasBurleson changed the title fxFlex ignores basis value when using breakpoints (api): fxFlex ignores basis value when using breakpoints Dec 15, 2017
@ThomasBurleson ThomasBurleson changed the title (api): fxFlex ignores basis value when using breakpoints (api): fxFlex ignores basis value when using breakpoints Dec 15, 2017
@ThomasBurleson ThomasBurleson changed the title (api): fxFlex ignores basis value when using breakpoints (api): fxFlex ignores basis value when using .lt-md Dec 15, 2017
@ThomasBurleson ThomasBurleson added question P4 Low-priority issue that needs to be resolved labels Dec 15, 2017
@alusev
Copy link
Author

alusev commented Dec 15, 2017

I updated the package and it didn't work for me.

captura-de-pantalla-2017-12-15-a-la s -10 23 10

@ThomasBurleson ThomasBurleson added P1 Urgent issue that should be resolved before the next re-lease and removed P4 Low-priority issue that needs to be resolved question labels Dec 15, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.13 milestone Dec 15, 2017
@ThomasBurleson ThomasBurleson mentioned this issue Dec 15, 2017
Closed
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a3204b2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set

Fixes angular#277
Fixes angular#280
Fixes angular#528
Fixes angular#534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Closed
@CaerusKaru CaerusKaru added has pr A PR has been created to address this issue and removed in-progress labels Feb 25, 2018
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
e23e2a0 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Merged
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
9a1d709 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes angular#277
Fixes angular#280
Fixes angular#323
Fixes angular#528
Fixes angular#534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
4ae757f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
1a3029f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 4, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
421a18a 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
45b29f2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a0ac344 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
7ab5d34 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
6f8c7ab 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings (#629)
1e96cea 
* fix for when flex-basis is unitless and 0
* fix for when no width/height is applied and flex-basis should be
  set
* fix for IE flex-basis with calc values
* fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

@CaerusKaru CaerusKaru

Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v5.0.0-beta.14
3 participants
@ThomasBurleson @CaerusKaru @alusev