Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

The value fxFlex "1 0 auto" translates to css flex: 1 1 auto #120

Closed
somombo opened this issue Jan 19, 2017 · 1 comment · Fixed by #122
Closed

The value fxFlex "1 0 auto" translates to css flex: 1 1 auto #120

somombo opened this issue Jan 19, 2017 · 1 comment · Fixed by #122
Assignees
@ThomasBurleson
Labels
has pr A PR has been created to address this issue pr: needs presubmit
Milestone
v2.0.0-beta.4

Comments

@somombo
Copy link
Contributor

somombo commented Jan 19, 2017 •
edited
Loading

See https://plnkr.co/edit/itCtZRcTBzc5DRAIBoPF :

fxFlex="1 0 auto"

results in

.css { 
  flex: 1 1 auto; 
  /* ... */ 
}

This can't be right?
@somombo somombo changed the title The value fxFlex="1 0 auto" translates to css { flex: 1 1 auto; } The value fxFlex "1 0 auto" translates to css flex: 1 1 auto Jan 19, 2017
ThomasBurleson added a commit that referenced this issue Jan 22, 2017
@ThomasBurleson
fix(flex): fix use of values with 'auto'
8cad5fc 
* for cases where the flex-basis === "auto", use the specified or default values of shrink and grow.
* add tests for flex-bases == "auto", "none", "initial", "noshrink", and "nogrow"

Fixes #120.
@ThomasBurleson ThomasBurleson mentioned this issue Jan 22, 2017
Merged
ThomasBurleson added a commit that referenced this issue Jan 22, 2017
@ThomasBurleson
fix(flex): fix use of values with 'auto'
09b14b3 
* for cases where the flex-basis === "auto", use the specified or default values of shrink and grow.
* add tests for flex-bases == "auto", "none", "initial", "noshrink", and "nogrow"

Fixes #120.
@ThomasBurleson ThomasBurleson added has pr A PR has been created to address this issue pr: needs presubmit labels Jan 22, 2017
@ThomasBurleson ThomasBurleson self-assigned this Jan 22, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.4 milestone Jan 22, 2017
andrewseguin pushed a commit that referenced this issue Jan 24, 2017
@ThomasBurleson @andrewseguin
fix(flex): fix use of values with 'auto' (#122)
04d24d5 
* for cases where the flex-basis === "auto", use the specified or default values of shrink and grow.
* add tests for flex-bases == "auto", "none", "initial", "noshrink", and "nogrow"

Fixes #120.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
has pr A PR has been created to address this issue pr: needs presubmit
Projects
None yet
Milestone
v2.0.0-beta.4
Development

Successfully merging a pull request may close this issue.

fix(fxFlex): fix use of values with 'auto' angular/flex-layout
2 participants
@ThomasBurleson @somombo